Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit centrifuge-gsrpc-v2 evaluation #762

Conversation

gmajor-encrypt
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#1281

Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gmajor-encrypt for the review! Let us know how to proceed 🙏

@mikiquantum
Copy link
Contributor

@gmajor-encrypt We have added support to Calls & Errors and added inline docs. We updated the deliverable commit: 71832cc

Please have another look, thank you.

@gmajor-encrypt
Copy link
Contributor Author

@mikiquantum I have updated my evaluation. let me know if there are any questions

@mikiquantum
Copy link
Contributor

@gmajor-encrypt Thanks for the evaluation. We have pushed another commit that addresses:

1. Tests link error, should be https://github.com/centrifuge/go-substrate-rpc-client/blob/events-parsing-v2-milestone-1/registry/registry_test.go
2. ``Dockerfile_milestone1`` test command error.
3. Lack ``CreateErrorRegistry`` function test
4. Increases code coverage

Thanks!

@gmajor-encrypt
Copy link
Contributor Author

gmajor-encrypt commented Mar 10, 2023

@semuelle I have completed my evaluation. What to do next?

@gmajor-encrypt
Copy link
Contributor Author

ping @semuelle @keeganquigley @Noc2

@semuelle semuelle self-assigned this Mar 14, 2023
@semuelle
Copy link
Member

Thank you for the evaluation, @gmajor-encrypt. I am happy to merge it.
We will transfer 15KSM to the Kusama account in the evaluation doc. Let me know if you haven't received anything in two weeks time.

@semuelle semuelle merged commit def7049 into w3f:master Mar 14, 2023
@gmajor-encrypt gmajor-encrypt deleted the evaluations/Centrifuge-GSRPC-m1-gmajor-encrypt branch March 15, 2023 00:58
@gmajor-encrypt
Copy link
Contributor Author

hi, @semuelle Hey,Looks like I still haven't received KSM, can you check it?

@semuelle
Copy link
Member

Hey @gmajor-encrypt. It seems that I forgot to forward your info to finances. I have done so now. Thanks for following up. My apologies!

@gmajor-encrypt gmajor-encrypt restored the evaluations/Centrifuge-GSRPC-m1-gmajor-encrypt branch April 17, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants