-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.25.0 #891
Comments
feedback from @filoozom
|
#893 helps with the proto behaviour |
892: fix: type export via `typesVersions` r=fryorcraken a=filoozom ## Problem Importing anything from TypeScript in `js-waku/lib/` (`v0.25.0-rc.0`) does not work. It can't find the types despite the `exports.*.types` in `package.json`. ## Solution This solution was inspired by `libp2p` ([example in ``@libp2p/interfaces`](https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interfaces/package.json#L24-L39)),` and just adds `typesVersions` to `package.json`. Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#folder-redirects-using- ## Notes - See #891 (comment) 893: fix: do not throw on lack of response r=fryorcraken a=fryorcraken Expected proto3 behaviour, just no message returned. Co-authored-by: Philippe Schommers <philippe@schommers.be> Co-authored-by: fryorcraken.eth <git@fryorcraken.xyz>
export issue #894 |
892: fix: type export via `typesVersions` r=fryorcraken a=filoozom ## Problem Importing anything from TypeScript in `js-waku/lib/` (`v0.25.0-rc.0`) does not work. It can't find the types despite the `exports.*.types` in `package.json`. ## Solution This solution was inspired by `libp2p` ([example in ``@libp2p/interfaces`](https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interfaces/package.json#L24-L39)),` and just adds `typesVersions` to `package.json`. Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#folder-redirects-using- ## Notes - See #891 (comment) Co-authored-by: Philippe Schommers <philippe@schommers.be>
892: fix: type export via `typesVersions` r=fryorcraken a=filoozom ## Problem Importing anything from TypeScript in `js-waku/lib/` (`v0.25.0-rc.0`) does not work. It can't find the types despite the `exports.*.types` in `package.json`. ## Solution This solution was inspired by `libp2p` ([example in ``@libp2p/interfaces`](https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interfaces/package.json#L24-L39)),` and just adds `typesVersions` to `package.json`. Documentation: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#folder-redirects-using- ## Notes - See #891 (comment) Co-authored-by: Philippe Schommers <philippe@schommers.be>
Done! |
Track the blockers for the next release.
A lot of refactoring has happen since the last release:
Release candidates under the
next
flag will be published to help prepare this release.Tasks
Remaining tasks to do before release
Investigate issues with Waku Relay being unreliable (related towas actually fine when playing around with examples.protons
performance issue? Slow compared to protobufjs ipfs/protons#51)Use a proto encoding/decoding that handles default as expected (ref: feat: cli option to not encode/decode default values ipfs/protons#48)tracked with Protobuf decode absent values as default #921. Not blocking as the problems encountered have been handled individually (e.g. https://github.com/status-im/js-waku/blob/d79984fdba57c8e89400fc2a47958d49e0ed9645/src/lib/waku_message/index.ts#L273)libp2p@0.38.0
once published. Not a strong blocker but a recommended one. chore(deps): bump libp2p to 0.38.0 #922The text was updated successfully, but these errors were encountered: