feat: spec test for connection manager

[danisharora099]

This PR addresses #1413:

• adds a spec test for the ConnectionManager module
• introduces Sinon into our testing suite, along with Chai + Mocha

Cases covered:

• tests that the peer:discovery event emitter when fired triggers a dial attempt for the peer
• for bootstrap peers:
  • dials to bootstrap peers are made until the maxBootstrapPeersAllowed flag is reached
• for non-bootstrap peers (peer-exchange for now):
  • dials to non-bootstrap peers always trigger a dial attempt to them without any upper limits

Notes

Please mention any test cases you think should be added/have been missed for ConnectionManager

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
Waku core	29.75 KB (-0.03% 🔽)	596 ms (-0.03% 🔽)	1.2 s (+12.39% 🔺)	1.8 s
Waku Simple Light Node	297.56 KB (-0.01% 🔽)	6 s (-0.01% 🔽)	4.7 s (-26.95% 🔽)	10.6 s
ECIES encryption	28.54 KB (0%)	571 ms (0%)	2 s (+14.21% 🔺)	2.6 s
Symmetric encryption	28.55 KB (0%)	572 ms (0%)	1.7 s (-14.46% 🔽)	2.3 s
DNS discovery	108.47 KB (0%)	2.2 s (0%)	3.8 s (+25.44% 🔺)	6 s
Privacy preserving protocols	135.51 KB (-0.01% 🔽)	2.8 s (-0.01% 🔽)	4.9 s (+2.43% 🔺)	7.7 s
Light protocols	31.78 KB (-0.06% 🔽)	636 ms (-0.06% 🔽)	2.3 s (+38.51% 🔺)	3 s
History retrieval protocols	30.42 KB (-0.03% 🔽)	609 ms (-0.03% 🔽)	1.8 s (+6.36% 🔺)	2.4 s
Deterministic Message Hashing	5.78 KB (0%)	116 ms (0%)	729 ms (+0.72% 🔺)	844 ms

[fryorcraken]

haha, good thing we're adding tests :)

[fryorcraken]

Are we checkng that peer exhcange peers are not limited by the max bootstrap peers?

[danisharora099]

yes, that is covered by the "should be called for every peer with PEER_EXCHANGE tags" scenario:

js-waku/packages/tests/tests/connection_manager.spec.ts

Line 173 in 694be5e

it("should be called for every peer with PEER_EXCHANGE tags", async function () {