Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing node_optional check #2025

Merged
merged 4 commits into from
Jun 18, 2024
Merged

fix: failing node_optional check #2025

merged 4 commits into from
Jun 18, 2024

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented May 30, 2024

Problem

We store multiaddrs for nodes from the deployed fleets hardcoded. This is unreliable, is our source of truth is the ENR Tree, and resolution of nodes should occur from the ENR Tree.

Solution

Remove the predfined list of nodes, and use the ENR Tree for resolution

Notes

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

Copy link

github-actions bot commented May 30, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 181.63 KB (0%) 3.7 s (0%) 20.7 s (+17.61% 🔺) 24.3 s
Waku Simple Light Node 181.56 KB (0%) 3.7 s (0%) 17 s (+7.52% 🔺) 20.7 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 4.8 s (+197.32% 🔺) 5.2 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 4 s (-7.99% 🔽) 4.4 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 12.2 s (-18.32% 🔽) 13.6 s
Peer Exchange discovery 74.15 KB (0%) 1.5 s (0%) 16.2 s (+62.96% 🔺) 17.7 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 16.9 s (+24.29% 🔺) 18.2 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 8.5 s (-6.25% 🔽) 9.2 s
Waku Filter 111.92 KB (0%) 2.3 s (0%) 17 s (+17.71% 🔺) 19.2 s
Waku LightPush 110.39 KB (0%) 2.3 s (0%) 16.4 s (+16.01% 🔺) 18.6 s
History retrieval protocols 110.91 KB (0%) 2.3 s (0%) 15.1 s (+53.84% 🔺) 17.3 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 2.1 s (+88.23% 🔺) 2.3 s

@danisharora099 danisharora099 marked this pull request as ready for review June 6, 2024 16:36
@danisharora099 danisharora099 requested a review from a team as a code owner June 6, 2024 16:36
@danisharora099 danisharora099 changed the title chore: remove predefine nodes list fix: failing node_optional check Jun 6, 2024
@danisharora099 danisharora099 merged commit 984fb94 into master Jun 18, 2024
11 checks passed
@danisharora099 danisharora099 deleted the rm/predfined-nodes branch June 18, 2024 17:43
@weboko weboko mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: remove predefined list of nodes
2 participants