Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove content_topic specific API #2081

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Jul 23, 2024

Problem

We have experimented with API for subscriptions and noticed it was not used.
Preferred way will be to use #2034

Solution

Remove unused files as per agreement https://discord.com/channels/1110799176264056863/1263257970058461214/1263257972453277746

@weboko weboko added enhancement New feature or request debt Technical debt marker labels Jul 23, 2024
@weboko weboko requested a review from a team as a code owner July 23, 2024 14:47
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 118.93 KB (-35.33% 🔽) 2.4 s (-35.33% 🔽) 30.3 s (+63.23% 🔺) 32.7 s
Waku Simple Light Node 183.78 KB (-0.18% 🔽) 3.7 s (-0.18% 🔽) 20.7 s (+3.99% 🔺) 24.3 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 6.4 s (-2.67% 🔽) 6.9 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 5.9 s (+22.02% 🔺) 6.4 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 11 s (-34.17% 🔽) 12.5 s
Peer Exchange discovery 74.22 KB (0%) 1.5 s (0%) 11 s (-22.61% 🔽) 12.5 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 13.7 s (+15.2% 🔺) 15.1 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 12.8 s (+20.44% 🔺) 13.6 s
Waku Filter 113.31 KB (0%) 2.3 s (0%) 12.7 s (-13.28% 🔽) 15 s
Waku LightPush 111.31 KB (0%) 2.3 s (0%) 17.8 s (-11.5% 🔽) 20 s
History retrieval protocols 111.81 KB (0%) 2.3 s (0%) 20.5 s (-3.77% 🔽) 22.8 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 3 s (+1.61% 🔺) 3.1 s

Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I'd suggest the PR title to be: chore: remove content_topic specific API

@weboko weboko changed the title chore: remove unused content_topics chore: remove content_topic specific API Jul 23, 2024
@weboko weboko merged commit 04bd518 into master Jul 23, 2024
11 of 12 checks passed
@weboko weboko deleted the weboko/remove-content-topics-utils branch July 23, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt marker enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants