Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some of audit errors #2107

Closed
wants to merge 1 commit into from
Closed

chore: fix some of audit errors #2107

wants to merge 1 commit into from

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Aug 22, 2024

Problem

70 audit problems with npm dependencies

Solution

Fix them

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 86.5 KB (-0.11% 🔽) 1.8 s (-0.11% 🔽) 4.7 s (-9.52% 🔽) 6.4 s
Waku Simple Light Node 154.17 KB (+0.06% 🔺) 3.1 s (+0.06% 🔺) 4 s (+37.97% 🔺) 7 s
ECIES encryption 22.83 KB (0%) 457 ms (0%) 644 ms (-17.66% 🔽) 1.1 s
Symmetric encryption 22.33 KB (0%) 447 ms (0%) 1.2 s (+48.13% 🔺) 1.7 s
DNS discovery 72.27 KB (+0.01% 🔺) 1.5 s (+0.01% 🔺) 2.8 s (+24.68% 🔺) 4.3 s
Peer Exchange discovery 73.75 KB (-0.06% 🔽) 1.5 s (-0.06% 🔽) 3 s (-14.1% 🔽) 4.5 s
Local Peer Cache Discovery 67.57 KB (+0.01% 🔺) 1.4 s (+0.01% 🔺) 2.5 s (-26.81% 🔽) 3.9 s
Privacy preserving protocols 38.91 KB (-0.06% 🔽) 779 ms (-0.06% 🔽) 1.9 s (+13.21% 🔺) 2.7 s
Waku Filter 81.07 KB (+0.09% 🔺) 1.7 s (+0.09% 🔺) 2.4 s (-39.77% 🔽) 4 s
Waku LightPush 78.59 KB (-0.01% 🔽) 1.6 s (-0.01% 🔽) 2.3 s (-6.75% 🔽) 3.8 s
History retrieval protocols 79.1 KB (+0.1% 🔺) 1.6 s (+0.1% 🔺) 2.3 s (+34.97% 🔺) 3.8 s
Deterministic Message Hashing 7.31 KB (0%) 147 ms (0%) 338 ms (-65.24% 🔽) 484 ms

@weboko
Copy link
Collaborator Author

weboko commented Aug 22, 2024

Introduces breaking changes, will follow up iteratively.

@weboko weboko closed this Aug 22, 2024
@weboko weboko deleted the weboko/audit-fix branch August 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant