Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import of base_protocol and networkConfig type guard #2109

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Aug 22, 2024

Problem

Couple of them:

  • import is broken;
  • type guard for networkConfig is not following defined type;

Solution

Fix it

@weboko weboko requested a review from a team as a code owner August 22, 2024 22:15
Copy link

github-actions bot commented Aug 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 86.6 KB (0%) 1.8 s (0%) 12.2 s (-14.64% 🔽) 13.9 s
Waku Simple Light Node 154.13 KB (+0.03% 🔺) 3.1 s (+0.03% 🔺) 7 s (-57.89% 🔽) 10.1 s
ECIES encryption 22.83 KB (0%) 457 ms (0%) 3.5 s (+10.76% 🔺) 3.9 s
Symmetric encryption 22.33 KB (0%) 447 ms (0%) 4.4 s (-25.55% 🔽) 4.9 s
DNS discovery 72.26 KB (0%) 1.5 s (0%) 15.5 s (+34.54% 🔺) 16.9 s
Peer Exchange discovery 73.79 KB (0%) 1.5 s (0%) 11.7 s (+67.62% 🔺) 13.1 s
Local Peer Cache Discovery 67.57 KB (0%) 1.4 s (0%) 6.6 s (+15.76% 🔺) 7.9 s
Privacy preserving protocols 38.92 KB (0%) 779 ms (0%) 7.3 s (+104.39% 🔺) 8.1 s
Waku Filter 81 KB (0%) 1.7 s (0%) 10.3 s (-5.58% 🔽) 12 s
Waku LightPush 78.6 KB (0%) 1.6 s (0%) 6.8 s (-43.82% 🔽) 8.4 s
History retrieval protocols 79.03 KB (0%) 1.6 s (0%) 11 s (-22.85% 🔽) 12.6 s
Deterministic Message Hashing 7.31 KB (0%) 147 ms (0%) 1.8 s (+8.89% 🔺) 2 s

@weboko weboko changed the title bug: fix import of base_protocol bug: fix import of base_protocol and networkConfig type guard Aug 22, 2024
@weboko weboko changed the title bug: fix import of base_protocol and networkConfig type guard fix: fix import of base_protocol and networkConfig type guard Aug 22, 2024
@weboko weboko changed the title fix: fix import of base_protocol and networkConfig type guard fix: import of base_protocol and networkConfig type guard Aug 22, 2024
@weboko weboko merged commit 8f56d90 into master Aug 23, 2024
12 of 14 checks passed
@weboko weboko deleted the weboko/fix-import branch August 23, 2024 09:44
@weboko weboko mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants