-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change amount of used peers to 2 #2111
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I would prefer we keep it as much as possible for now considering how unstable the nodes infrastructure is for light clients (high churn), RFC is indeed the source of truth.
Please make the shot here in whatever direction you think is the best!
@danisharora099 I think it should be fine. We have renewal in place so it should be essentially the same as current behavior and worst case is that 2 of the nodes are broken. Next improvement would be to enable auto retrials on sent messages in LightPush. |
Problem
As per RFC protocols should use 2 peers https://github.com/waku-org/specs/blob/master/standards/application/req-res-reliability.md#sending-with-redundancy
But 3 are used
Solution
Make them use 2