Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mandate .js extensions for imports #2128

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

danisharora099
Copy link
Collaborator

Problem

The codebase currently uses .js extensions on all imports. This is not caught by the compiler/eslint, and these non-.js extensions can leak in.

Solution

Add an eslint check to catch non .js imports

@danisharora099 danisharora099 requested a review from a team September 11, 2024 05:38
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 82.97 KB (0%) 1.7 s (0%) 2.8 s (+45.83% 🔺) 4.5 s
Waku Simple Light Node 134.85 KB (0%) 2.7 s (0%) 2.9 s (-22.88% 🔽) 5.6 s
ECIES encryption 22.94 KB (0%) 459 ms (0%) 877 ms (+12.02% 🔺) 1.4 s
Symmetric encryption 22.39 KB (0%) 448 ms (0%) 1.2 s (+374.71% 🔺) 1.7 s
DNS discovery 72.28 KB (0%) 1.5 s (0%) 2.6 s (+78.63% 🔺) 4.1 s
Peer Exchange discovery 73.79 KB (0%) 1.5 s (0%) 1.7 s (-10.01% 🔽) 3.2 s
Local Peer Cache Discovery 67.63 KB (0%) 1.4 s (0%) 1.9 s (-2.93% 🔽) 3.3 s
Privacy preserving protocols 74.8 KB (0%) 1.5 s (0%) 2.6 s (+44.37% 🔺) 4.1 s
Waku Filter 78.06 KB (0%) 1.6 s (0%) 2.5 s (+61.84% 🔺) 4.1 s
Waku LightPush 75.58 KB (0%) 1.6 s (0%) 2.7 s (+24.01% 🔺) 4.2 s
History retrieval protocols 75.96 KB (0%) 1.6 s (0%) 2 s (+37.93% 🔺) 3.5 s
Deterministic Message Hashing 7.38 KB (0%) 148 ms (0%) 109 ms (-51.44% 🔽) 256 ms

Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great success!

@danisharora099 danisharora099 merged commit 9d9a696 into master Sep 13, 2024
10 of 11 checks passed
@danisharora099 danisharora099 deleted the chore/mandate-extensions-import branch September 13, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants