Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: discovery peer filtering for relay shard #1804

Merged
merged 3 commits into from
Jun 20, 2023
Merged

feat: discovery peer filtering for relay shard #1804

merged 3 commits into from
Jun 20, 2023

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Jun 15, 2023 •
edited
Loading

Description

Filter peer discovered by static shard information

Changes

  • added predicate based on relay shard info.
  • apply predicate when peers are discovered
  • test predicate

Step 3 of #1776

TODO: test predicate proc,

@SionoiS SionoiS marked this pull request as ready for review June 19, 2023 22:30
@SionoiS
Copy link
Contributor Author

SionoiS commented Jun 19, 2023

Hopefully we gucci this time...

jm-clius
jm-clius reviewed Jun 20, 2023
View reviewed changes
waku/v2/waku_discv5.nim Outdated Show resolved Hide resolved
jm-clius
jm-clius approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great to see. The comments below are only nitpicks or style suggestions, so feel free to implement as you see fit. Next steps are: configuring a (new) fleet with static sharding and (in parallel?) considering moving discv5 out of the waku_node.

waku/v2/waku_discv5.nim Outdated Show resolved Hide resolved
tests/v2/test_waku_discv5.nim Show resolved Hide resolved
SionoiS and others added 2 commits June 20, 2023 07:05
@SionoiS @jm-clius
Update waku/v2/waku_discv5.nim
7e7e4fe 
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
@SionoiS
Fixes & Style
3885e17
@SionoiS SionoiS merged commit a4da87b into master Jun 20, 2023
13 checks passed
@SionoiS SionoiS deleted the feat-discovery-filtering branch June 20, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SionoiS @jm-clius