Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove references to v2 #1898

Merged
merged 4 commits into from
Aug 9, 2023
Merged

chore: remove references to v2 #1898

merged 4 commits into from
Aug 9, 2023

Conversation

jm-clius
Copy link
Contributor

@jm-clius jm-clius commented Aug 8, 2023

Closes #1767

Removes references to v2, including removing it from the directory structure and import paths of individual modules.
I've also updated references in docs, tried to clean up the Makefile and CI processes, and gone through all other references to make sure they're up to date.
Please review if I've missed anything important.

Note that some binary targets (specifically wakunode2 and chat2) have not been renamed, as their names are integral to many existing scripts.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1898

@jm-clius jm-clius marked this pull request as ready for review August 9, 2023 13:36
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jm-clius amazing!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super satisfying one :p ! Thanks for it !

@jm-clius jm-clius merged commit b9d5d28 into master Aug 9, 2023
12 checks passed
@jm-clius jm-clius deleted the chore/remove-v2-refs branch August 9, 2023 17:11
@SionoiS
Copy link
Contributor

SionoiS commented Aug 10, 2023

Beautiful !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Milestone] Move Waku v1 and Waku-Bridge to new repos
5 participants