Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding lint job to the CI #2925

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Jul 23, 2024

Description

Adding a lint job in the CI checking for equality with the output of nph v0.5.1, and running nph on files that weren't properly linted

Using nim-libp2p's CI as reference

Copy link

github-actions bot commented Jul 23, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2925

Built from a32b821

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks so much for it! 💯

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!!

@gabrielmer gabrielmer merged commit 086cc8e into master Jul 23, 2024
15 of 17 checks passed
@gabrielmer gabrielmer deleted the chore-add-lint-check-to-CI branch July 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants