Include operation name in parsed query #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I can't look at this until the CLA is signed. |
robhanlon22
force-pushed
the
include-operation-name-in-parsed-query
branch
from
148c6a1
to
3680a95
Compare
robhanlon22
force-pushed
the
include-operation-name-in-parsed-query
branch
from
3680a95
to
0f63d8c
Compare
|
@hlship CLA signed! Sorry about the delay. |
|
This seems incomplete; there's no tests, and no API for extracting the named operation from the map. I'm just not sure what's the point of this change. |
|
Please see notes above and reopen with tests, and a rationale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for debug, diagnostic, or metrics purposes.