Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dutch #539

Merged
merged 9 commits into from
Nov 23, 2023
Merged

Improve dutch #539

merged 9 commits into from
Nov 23, 2023

Conversation

HendrikJan
Copy link
Contributor

@HendrikJan HendrikJan commented Nov 13, 2023

Correct in Dutch is "komend uur", not "komende uur".
And there are some other combinations that were not detected yet: "aankomende maand", "komend jaar" and some more.

In this PR both
"komend" and "komende",
"volgend" and "volgende",
"vorig" and "vorige",
"aankomend" and "aankomende"
are allowed.

Changed test for "volgende maand" into "aankomende maand", as there are already tests for "volgende week", "volgende dag", "volgend jaar" and no tests for "aankomende".

@HendrikJan
Copy link
Contributor Author

The test will currently fail because the main branch I forked from has a failing test. See #538

@HendrikJan HendrikJan marked this pull request as draft November 13, 2023 15:20
@HendrikJan HendrikJan marked this pull request as ready for review November 13, 2023 16:00
Copy link
Owner

@wanasit wanasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement.

I added a few comments. It would be nice if you could address them, but if you don't have time I will merge it next week.

test/nl/nl_relative.test.ts Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 91.332% (-0.04%) from 91.37%
when pulling 2c2d8af on HendrikJan:improve_dutch
into 5ebfcc0 on wanasit:master.

@wanasit wanasit merged commit f00e9ef into wanasit:master Nov 23, 2023
2 checks passed
@HendrikJan HendrikJan deleted the improve_dutch branch November 23, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants