Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependencies of less commonly used functionalities optional #10

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Make dependencies of less commonly used functionalities optional #10

merged 1 commit into from
Sep 22, 2023

Conversation

BLKSerene
Copy link
Contributor

While functions like tokenization and POS tagging are commonly used by LaoNLP users, other functionalities are less commonly used but have heavier dependencies, so this PR makes them optional.

The Installation Options part of README is added accordingly to mimic that of PyThaiNLP, so when more and more functionalities are added to LaoNLP in future releases, the extra dependencies could be conveniently added here.

@BLKSerene BLKSerene changed the title Make dependencies of some functionalities optional Make dependencies of less commonly used functionalities optional Sep 22, 2023
Copy link
Owner

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💯

@wannaphong wannaphong merged commit edbe681 into wannaphong:master Sep 22, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants