Implement num_to_laoword
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed regression tests failed. Do you want me to fix this PR or open a new one? |
Can you fix in this PR? |
gunsodo
force-pushed
the
feat/number-to-lao
branch
from
544871e
to
0174b26
Compare
|
@wannaphong Still, there is a high chance the CI checks will still fail because of the Let me know if you want me to cap the coveralls version as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #9.
Implemented
num_to_laowordby using PyThaiNLP-style. Decided to rename the function fromnumber2laotonum_to_laowordto maintain the consistency with other APIs within the same module. Test cases added to the suite.Please let me know if there requires any fix. I myself is not a Lao-language user and was trying to refer from this Youtube lesson and this repo so I might have missed a few points.