Skip to content

Commit

Permalink
docs: remove reference to Node 10 incompatibility
Browse files Browse the repository at this point in the history
The bug in V8 that meant we couldn't instrument Node 10 was fixed and
Node 10.4.0 shipped with a newer version of V8.

This is the original bug report in Node:
nodejs/node#20516

This is the PR that fixed it in Node:
nodejs/node#19989
  • Loading branch information
watson committed Jul 17, 2018
1 parent 178f701 commit b1b068f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion docs/compatibility.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ image::https://raw.githubusercontent.com/nodejs/Release/master/schedule.png[]
Some versions of Node.js contain bugs or issues that limit our ability to instrument them correctly.
The following versions of Node.js are known to not be fully instrumented:

- v10.x - Async/Await in Node.js 10 is currently buggy and can therefore not be supported (https://github.com/nodejs/node/issues/20516:[nodejs/node#20516])
- v8.1.x - Recommended solution: Upgrade to v8.2.0 or higher to get full support
- v8.0.x - Recommended solution: Upgrade to v8.2.0 or higher to get full support

Expand Down
3 changes: 0 additions & 3 deletions test/instrumentation/modules/hapi.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ var semver = require('semver')
// hapi 17+ requires Node.js 8.9.0 or higher
if (semver.lt(process.version, '8.9.0') && semver.gte(pkg.version, '17.0.0')) process.exit()

// hapi does not work on Node.js 10 because of https://github.com/nodejs/node/issues/20516
if (semver.gte(process.version, '10.0.0-rc')) process.exit()

var http = require('http')

var Hapi = require('hapi')
Expand Down

0 comments on commit b1b068f

Please sign in to comment.