Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.3-7.10] Add centralized request service #4826

Closed
wants to merge 1 commit into from

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Nov 8, 2022

Backport 34c3fae from #4758.

* create service

* Improve service functionality

* add timeout handling

* Improve code quality

* Fix issue that caused infinite loop

* separate interceptor initialization

* add interceptor to plugin start

* fix double reload and add abort

* Add function to disable requests externally

* Add auth validation on server to disable requests

* Update changelog

* Add missing parameters verification

* Add missing parameter validation

* Add reload to interceptor

* Change structure of code

* Implement new service

* Fix bug

* Fix errors

* Create unit tests

* Fix bad reference to previous PR in changelog

* Add missing previous change in changelog

(cherry picked from commit 34c3fae)
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Jest Test Coverage % values
Statements 6.97% ( 2548 / 36536 )
Branches 2.76% ( 779 / 28243 )
Functions 4.65% ( 415 / 8929 )
Lines 7.06% ( 2467 / 34957 )

@Tostti
Copy link
Member Author

Tostti commented Nov 8, 2022

Tested backport, works as expected on this branch

@Tostti
Copy link
Member Author

Tostti commented Nov 8, 2022

Closed due to errors detected on internal tests. Base PR #4758. was reverted.

@Tostti Tostti closed this Nov 8, 2022
@AlexRuiz7 AlexRuiz7 deleted the backport-4758-to-4.3-7.10 branch December 14, 2022 10:46
@AlexRuiz7 AlexRuiz7 restored the backport-4758-to-4.3-7.10 branch December 14, 2022 10:49
@AlexRuiz7 AlexRuiz7 deleted the backport-4758-to-4.3-7.10 branch December 14, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant