FEAT: Optional argument whitespace in the required rule
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional argument
whitespaceto therequiredvalidation rule.The parameter has a default value
'pre'which means that the validator will preserve the whitespace in the input and any strings that are only whitespace will pass the validation.It supports a value
'trim'which trims the whitespace and then the validator evaluates the result. A whitespace only string would not pass the validation in this case.Note: This only affects the validations, the original input is not modified.
Bonus: This PR also introduces
cross-envand updates the test script accordingly.