Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for data-cy-debug="tableRow" #17

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

mhdirkse
Copy link
Member

@mhdirkse mhdirkse commented Aug 5, 2024

No description provided.

@mhdirkse
Copy link
Member Author

mhdirkse commented Aug 5, 2024

Ik heb dit op mijn laptop getest. Het gaat in CI/CD pas slagen als er een nieuwe ladybug-frontend release in het FF! zit.

Copy link

@MarkvdVorst MarkvdVorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using the data-cy tag to get the tablerow, it's better to use the getTableRows command now. This should be applied everywhere where .find or .get is used to get the table rows

@mhdirkse
Copy link
Member Author

mhdirkse commented Aug 6, 2024

There is no getTableRows command yet. I think it is not a good idea to create it. Using a get or find to query the data-cy tag is only a single statement that is easy to understand. The code does not become easier to understand with the new function, because then you have to read the function body if you want to understand what you are doing.

We already use data-cy* attributes to make the test independent of implementation details.

I also wonder whether debugging will become easier when the test fails. Cypress does not give correct line numbers when showing an error. Can you live with it when I merge this PR?

@MarkvdVorst
Copy link

MarkvdVorst commented Aug 6, 2024

Please fix the failing tests first and then I'll take a look at it again. Just hit the "re-request review" button on top right when you're done and I'll see it pop up in my notifications.

@mhdirkse
Copy link
Member Author

mhdirkse commented Aug 6, 2024

The fix is that the FF! should have the new data-cy* tags. I am working on that.

@mhdirkse
Copy link
Member Author

mhdirkse commented Aug 6, 2024

FF! PR frankframework/frankframework#7264.

@ricklue ricklue merged commit 0b90573 into main Aug 9, 2024
1 check passed
@MarkvdVorst MarkvdVorst deleted the update-for-data-cy-debug-tableRow branch August 9, 2024 11:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants