Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

"cannot unmarshal DNS message" using weavedns to resolve email-smtp.us-east-1.amazonaws.com #1306

Closed
tomwilkie opened this issue Aug 16, 2015 · 5 comments
Closed

"cannot unmarshal DNS message" using weavedns to resolve email-smtp.us-east-1.amazonaws.com #1306

tomwilkie opened this issue Aug 16, 2015 · 5 comments
Assignees
@tomwilkie
Labels
bug [component/dns]
Milestone
1.0.2

Comments

@tomwilkie
Copy link
Contributor

This bug shows a similar problem existed with consul dns:

golang/go#11070

Looks like the following is happening:
@rade rade added this to the current milestone Aug 16, 2015
@tomwilkie tomwilkie self-assigned this Aug 16, 2015
@tomwilkie tomwilkie mentioned this issue Aug 16, 2015
Merged
@rade
Copy link
Member

rade commented Aug 16, 2015

Is this issue present in the old weavedns too? If so it would be good to get a fix in for 1.0.2, assuming it is easy.

@rade
Copy link
Member

rade commented Aug 16, 2015

Is this issue present in the old weavedns too?

Pretty sure it is. @inercia?

@inercia
Copy link
Contributor

inercia commented Aug 17, 2015

Yes, that seems to be the cause. Not sure about the solution, though. Some people suggest setting Compress = true for all messages to clients, maybe as a temporary solution...

@rade
Copy link
Member

rade commented Aug 17, 2015

Not sure about the solution, though.

What's wrong with this? Can't we perform the same test in the old code?

@rade rade modified the milestones: 1.0.2, current Aug 17, 2015
@inercia
Copy link
Contributor

inercia commented Aug 17, 2015

I'm backporting #1307 for 1.0.2

@inercia inercia mentioned this issue Aug 17, 2015
Merged
@rade rade closed this as completed in 7fb597a Aug 17, 2015
rade added a commit that referenced this issue Aug 17, 2015
@rade
Merge pull request #1307 from weaveworks/1306-dns-recurse-compress
bbc91c1 
Compress recursive answers if they are too big.

Fixes #1306.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomwilkie tomwilkie

Labels
bug [component/dns]
Projects
None yet
Milestone
1.0.2
Development

No branches or pull requests
3 participants
@rade @tomwilkie @inercia