Fix shadow-dom/focus-navigation/focus-navigation-web-component-input-type-radio.html for Safari #38410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt1m
approved these changes
Feb 8, 2023
| @@ -8,7 +8,7 @@ | |||
| <script src="resources/focus-utils.js"></script> | |||
|
|
|||
| <template id="custom-radio"> | |||
| <input type="radio"> | |||
| <span aria-role="radio" tabindex="0">🔘</span> | |||
There was a problem hiding this comment.
The test name should be changed, input-type-radio is no longer accurate.
Though I wonder if there's any point to this test now that we're changing it to a span? Will leave it to your judgement :)
There was a problem hiding this comment.
Oh, that's a good point. I'd rename it to focus-navigation-web-component-radio.html
…type-radio.html for Safari This test was erroneously assuming that radio buttons are focusable. Use a span with ARIA role=radio and tabindex=0 instead as this is not the case in Safari. Also rename the test accordingly.
rniwa
force-pushed
the
fix-focus-navigation-web-component-input-type-radio.html
branch
from
5060f34
to
b348cd4
Compare
rniwa
deleted the
fix-focus-navigation-web-component-input-type-radio.html
branch
marcoscaceres
pushed a commit
that referenced
this pull request
Mar 28, 2023
…type-radio.html for Safari (#38410) This test was erroneously assuming that radio buttons are focusable. Use a span with ARIA role=radio and tabindex=0 instead as this is not the case in Safari. Also rename the test accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was erroneously assuming that radio buttons are focusable. Use a span with ARIA role=radio and tabindex=0 instead as this is not the case in Safari.