Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement the new GitHub host keys #101

Closed
wants to merge 1 commit into from
Closed

fix: implement the new GitHub host keys #101

wants to merge 1 commit into from

Conversation

nikolay
Copy link

@nikolay nikolay commented Nov 17, 2021

The old GitHub RSA and DSA host keys are no longer supported: https://github.blog/2021-09-01-improving-git-protocol-security-github/

@mpdude
Copy link
Member

mpdude commented Nov 18, 2021

Thank you @nikolay for this PR!

Adding the two new keys is definetly a good thing. The ssh-rsa key you removed, however, seems to be still supported by GitHub.

Is it really necessary to drop it? I am afraid of BC problems for users of this action, especially on older runners.

@mpdude mpdude closed this in dc622c5 Nov 20, 2021
camilo-celis pushed a commit to pexip/ssh-agent that referenced this pull request Jul 21, 2022
Closes webfactory#101 as well.

Co-authored-by: Matthias Pigulla <mp@webfactory.de>
camilo-celis pushed a commit to pexip/ssh-agent that referenced this pull request Jul 21, 2022
Closes webfactory#101 as well.

Co-authored-by: Matthias Pigulla <mp@webfactory.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants