Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Lightning CSS (renamed @parcel/css) #191

Closed
LekoArts opened this issue Sep 9, 2022 · 4 comments · Fixed by #192
Closed

Feature: Add Lightning CSS (renamed @parcel/css) #191

LekoArts opened this issue Sep 9, 2022 · 4 comments · Fixed by #192

Comments

@LekoArts
Copy link

LekoArts commented Sep 9, 2022

Feature Proposal

Devon released Lightning CSS: https://twitter.com/devongovett/status/1567898042787049473
It's the same as @parcel/css but now with a different name.

https://lightningcss.dev/

So it'll be a matter of changing dependencies and names to support this new, old package.

I'm happy to do the work if y'all can give me directions on how you typically handle such renames. I'd imagine just removing the parcelCssMinify option is not ideal as it would be a breaking change. So maybe gracefully handle that option for now and fallback to the new lightningCssMinify option then? So the options passed to parcelCssMinify would be just passed through to lightningCssMinify.

Thanks for your work and the plugins!

@ghost
Copy link

ghost commented Sep 9, 2022

I hope we get this soon. Currently @parcel/css only re-exports lightningcss. So the parcelCssMinify should be able to use the new package under the hood without any difference

@LekoArts
Copy link
Author

LekoArts commented Sep 9, 2022

Ah, I didn't know that, thanks for the comment! That should make things even easier 👍

@alexander-akait
Copy link
Member

Done #192 + docs updated (old solution will work too, but I recommend to migrate on the new function, the old was removed in the next major release)

@LekoArts
Copy link
Author

LekoArts commented Sep 9, 2022

Thanks for the quick turnaround, appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants