Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): SWC minifier & Lightning CSS #36577

Closed
wants to merge 7 commits into from
Closed

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Sep 9, 2022

Description

This adds a MODERN_MINIFY flag for Gatsby 5. It adds:

Note: @parcel/css was rebranded to Lightning CSS, I opened webpack-contrib/css-minimizer-webpack-plugin#191

Why Gatsby 5 only? Because in companion with #36522 we're dropping more support for older browsers and this change will remove polyfills for old browsers (see e.g. https://swc.rs/docs/configuration/minification#jscminifymangle)

Benchmarks

Haven't done any yet 😬

Dependency Bumps

Documentation

Afaik we don't have public docs about this. But we'll need to open the umbrella issue at some point and set up the shortlink.

Related Issues

[ch55427]

@LekoArts LekoArts added topic: webpack/babel Webpack or babel topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) labels Sep 9, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 9, 2022
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 9, 2022
@LekoArts LekoArts marked this pull request as ready for review September 9, 2022 06:55
@LekoArts LekoArts added this to the Gatsby 5 milestone Sep 9, 2022
@LekoArts LekoArts marked this pull request as draft September 13, 2022 05:55
@LekoArts
Copy link
Contributor Author

Marked as draft until we tested this a bit further

@LekoArts LekoArts removed this from the Gatsby 5 milestone Oct 26, 2022
@LekoArts
Copy link
Contributor Author

Closing for now and will revisit this in the new year

@LekoArts LekoArts closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) topic: webpack/babel Webpack or babel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant