Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct index when parsing publicHost #888

Merged
merged 2 commits into from
Apr 26, 2017
Merged

Use correct index when parsing publicHost #888

merged 2 commits into from
Apr 26, 2017

Conversation

phairoh
Copy link
Contributor

@phairoh phairoh commented Apr 24, 2017

2.4.3 introduced checking of the host header and options for setting the public host however when parsing the publicHost it was still using the index of : from the host header hostname. This corrects that.

@codecov
Copy link

codecov bot commented Apr 24, 2017

Codecov Report

Merging #888 into master will increase coverage by 1.6%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #888     +/-   ##
=========================================
+ Coverage   72.01%   73.62%   +1.6%     
=========================================
  Files           4        4             
  Lines         436      436             
  Branches      130      130             
=========================================
+ Hits          314      321      +7     
+ Misses        122      115      -7
Impacted Files Coverage Δ
lib/Server.js 83% <100%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d08d1e...f26f985. Read the comment docs.

@phairoh
Copy link
Contributor Author

phairoh commented Apr 25, 2017

Added a few tests for the checkHost method. Validation.test.js seemed like the proper place for these but I wasn't entirely sure.

@sokra sokra merged commit 99b273c into webpack:master Apr 26, 2017
@sokra
Copy link
Member

sokra commented Apr 26, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants