Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix webpack repo links that use legacy branch name #7036

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

hex2dec
Copy link
Contributor

@hex2dec hex2dec commented Oct 18, 2023

The new default branch name of webpack repository is main, and the links in the docs still use the legacy branch name master.

The new default branch name of webpack repository is `main`,
and the links in the docs still use the legacy branch name `master`.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hex2dec / name: William Huang (6a30c91)

@vercel
Copy link

vercel bot commented Oct 18, 2023

@hex2dec is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@hex2dec
Copy link
Contributor Author

hex2dec commented Oct 22, 2023

hi @chenxsan, the E2E testing failed because sass and dart2js don't support the latest Node.js 21 at the moment. Can we fix the GitHub Actions CI to use Node.js 20. If so, i will submit a PR.

@chenxsan
Copy link
Member

hi @chenxsan, the E2E testing failed because sass and dart2js don't support the latest Node.js 21 at the moment. Can we fix the GitHub Actions CI to use Node.js 20. If so, i will submit a PR.

Probably wait for Node.21 to get it fixed? nodejs/node#50269

@hex2dec
Copy link
Contributor Author

hex2dec commented Oct 22, 2023

@chenxsan

Thanks! I found that Node.js has added the navigator.userAgent property, so we wait for it to release a new version.

The dart2js also fixes a missing navigator.userAgent in Node.js 21.

@hex2dec
Copy link
Contributor Author

hex2dec commented Oct 25, 2023

hi @chenxsan, the Node.js v21.1.0 has been released. How can i recheck the e2e testing?

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 8:10am

Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@chenxsan chenxsan merged commit a9162b0 into webpack:main Oct 25, 2023
8 checks passed
@hex2dec hex2dec deleted the fix-branch-name branch October 25, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants