-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/optional chaining #11221
Feature/optional chaining #11221
Conversation
For maintainers only:
|
d278524
to
39b8425
Compare
* @returns {boolean} | ||
*/ | ||
module.exports = function (config) { | ||
if (config.mode === "production") return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terser does not supports optional chaining yet.
terser/terser#567
nullish coalescing works on try.terser.org, but not optimized.
39b8425
to
fb561e9
Compare
0fbb348
to
1eacb07
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Thanks |
Thanks! Is there an estimation on when this will be released? |
@dreyks It's already released https://github.com/webpack/webpack/releases/tag/v5.0.0-beta.25 |
will it be ported to the stable branch or will it only be available in webpack 5? |
@dreyks only for webpack@5 |
btw terser 5.2.0 is out now with the optional chaining support |
What kind of change does this PR introduce?
closes #11186
closes #10227
cherry-pick from #11198
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing