♻️ Let PyogrioReader return geodataframe only instead of tuple #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify downstream slicing tasks on an geopandas.GeoDataFrame by returning a single geodataframe per iteration instead of a tuple of (filepath, geodataframe). The source filename(s) can be obtained by looping over the original input DataPipe iterator.
weiji14
force-pushed
the
tuple_to_geodataframe
branch
from
b825c11
to
515d9a6
Compare
weiji14
added a commit
that referenced
this pull request
Sep 7, 2022
Forgot to edit the unit test's docstring. Patches #33.
weiji14
added a commit
that referenced
this pull request
Sep 7, 2022
Forgot to edit the unit test's docstring. Patches #33.
weiji14
added a commit
that referenced
this pull request
Sep 7, 2022
Just a random collection of mostly documentation-related patches. Patches type-hints in #52, isort imports in #35, mention functional name of IterDataPipe in walkthroughs #8 and #20, and remove mention of returned tuple to patch #33. * 🏷️ Add specific type hints for mask_datapipe in geopandas.py Should be either an xarray.DataArray or xarray.Dataset. * 🚨 Sort spatialpandas imports in datashader.py Ran isort to sort spatialpandas.geometry imports alphabetically. Also intersphinx linked the `.crs` attribute to geopandas.GeoDataFrame.crs. * 💬 Mention functional name of IterDataPipe in walkthroughs So people don't get confused on why the class-form like `Collator` is mentioned but `.collate` was used instead. * 📝 Remove mention of tuple being returned in test_pyogrio_reader Forgot to edit the unit test's docstring. Patches #33. * 🍻 It's GeoPackage and GeoDataFrame, not GeoTIFF and DataArray Need to be more careful when copying and pasting stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify downstream slicing tasks on an geopandas.GeoDataFrame by returning a single geodataframe per iteration instead of a tuple of (filepath, geodataframe). The source filename(s) can be obtained by looping over the original input DataPipe iterator.
Relates to #31 and handles bullet point in #32 (comment). Also xref similar PR at #24.