fix(logs): respect quiet option (#492)

wellwelwel · Jul 1, 2024 · aabb1b3 · aabb1b3
1 parent 812744d
commit aabb1b3
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 37 deletions.
diff --git a/src/services/each.ts b/src/services/each.ts
@@ -2,6 +2,7 @@
 import type { Configs } from '../@types/poku.js';
 import { format } from './format.js';
 import { Write } from '../services/write.js';
+import { isQuiet } from '../parsers/output.js';
 
 const eachCore = async (
   type: keyof Required<Pick<Configs, 'beforeEach' | 'afterEach'>>,
@@ -14,33 +15,37 @@ const eachCore = async (
   }
 
   const cb = configs[type];
+  const showLogs = !isQuiet(configs);
 
   const cbName = cb.name !== type ? cb.name : 'anonymous function';
 
-  Write.log(
-    `    ${format('◯').dim().info()} ${format(`${type}: ${cbName}`)
-      .dim()
-      .italic()}`
-  );
+  showLogs &&
+    Write.log(
+      `    ${format('◯').dim().info()} ${format(`${type}: ${cbName}`)
+        .dim()
+        .italic()}`
+    );
 
   try {
     await cb();
 
     return true;
   } catch (error) {
-    Write.log(
-      format(`    ✘ ${type} callback failed ${format(`› ${cbName}`).dim()}`)
-        .fail()
-        .bold()
-    );
-    Write.log(format(`      ├─ Who's trying to run this ${type}?`).fail());
-    Write.log(
-      format(`      │ └─ ${format(fileRelative).fail().underline()}`).fail()
-    );
+    if (showLogs) {
+      Write.log(
+        format(`    ✘ ${type} callback failed ${format(`› ${cbName}`).dim()}`)
+          .fail()
+          .bold()
+      );
+      Write.log(format(`      ├─ Who's trying to run this ${type}?`).fail());
+      Write.log(
+        format(`      │ └─ ${format(fileRelative).fail().underline()}`).fail()
+      );
 
-    if (error instanceof Error) {
-      Write.log(format('      ├─ Message:').fail());
-      Write.log(format(`      │ └─ ${error.message}`).fail());
+      if (error instanceof Error) {
+        Write.log(format('      ├─ Message:').fail());
+        Write.log(format(`      │ └─ ${error.message}`).fail());
+      }
     }
 
     return false;

diff --git a/src/services/run-tests.ts b/src/services/run-tests.ts
@@ -74,13 +74,17 @@ export const runTests = async (
       passed = false;
 
       if (configs?.failFast) {
-        Write.hr();
-        Write.log(
-          `  ${format('ℹ').fail()} ${format('fail-fast').bold()} is enabled`
-        );
+        if (showLogs) {
+          Write.hr();
+          Write.log(
+            `  ${format('ℹ').fail()} ${format('fail-fast').bold()} is enabled`
+          );
+        }
+
         break;
       }
     }
+
     /* c8 ignore stop */
   }
 
@@ -99,6 +103,7 @@ export const runTestsParallel = async (
   const filesByConcurrency: string[][] = [];
   const concurrencyLimit = configs?.concurrency || 0;
   const concurrencyResults: (boolean | undefined)[][] = [];
+  const showLogs = !isQuiet(configs);
 
   if (concurrencyLimit > 0) {
     for (let i = 0; i < files.length; i += concurrencyLimit) {
@@ -143,8 +148,10 @@ export const runTestsParallel = async (
     return concurrencyResults.every((group) => group.every((result) => result));
     /* c8 ignore start */
   } catch (error) {
-    Write.hr();
-    error instanceof Error && console.error(error.message);
+    if (showLogs) {
+      Write.hr();
+      error instanceof Error && console.error(error.message);
+    }
 
     return false;
   }

diff --git a/test/e2e/before-and-after-each.test.ts b/test/e2e/before-and-after-each.test.ts
@@ -16,7 +16,7 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/success', {
         noExit: true,
-        quiet: true,
+
         beforeEach: prepareService,
         afterEach: resetService,
       });
@@ -31,7 +31,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/fail', {
         noExit: true,
-        quiet: true,
         beforeEach: prepareService,
         afterEach: resetService,
       });
@@ -48,7 +47,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/success', {
         noExit: true,
-        quiet: true,
         beforeEach: () => prepareService(),
         afterEach: () => resetService(),
       });
@@ -63,7 +61,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/fail', {
         noExit: true,
-        quiet: true,
         beforeEach: () => prepareService(),
         afterEach: () => resetService(),
       });
@@ -80,7 +77,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/success', {
         noExit: true,
-        quiet: true,
         beforeEach: async () => await prepareService(),
         afterEach: async () => await resetService(),
       });
@@ -95,7 +91,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/fail', {
         noExit: true,
-        quiet: true,
         beforeEach: async () => await prepareService(),
         afterEach: async () => await resetService(),
       });
@@ -112,7 +107,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/success', {
         noExit: true,
-        quiet: true,
         beforeEach: () => true,
         afterEach: () => true,
       });
@@ -127,7 +121,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/fail', {
         noExit: true,
-        quiet: true,
         beforeEach: () => true,
         afterEach: () => true,
       });
@@ -144,7 +137,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/success', {
         noExit: true,
-        quiet: true,
         beforeEach: function () {
           return;
         },
@@ -163,7 +155,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/fail', {
         noExit: true,
-        quiet: true,
         beforeEach: function () {
           return;
         },
@@ -184,7 +175,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/success', {
         noExit: true,
-        quiet: true,
         beforeEach: crashIt,
         afterEach: resetService,
       });
@@ -199,7 +189,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/success', {
         noExit: true,
-        quiet: true,
         beforeEach: prepareService,
         afterEach: crashIt,
       });
@@ -214,7 +203,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/success', {
         noExit: true,
-        quiet: true,
         beforeEach: crashItAgain,
         afterEach: resetService,
       });
@@ -229,7 +217,6 @@ test(async () => {
     await it(async () => {
       const code = await poku('./fixtures/success', {
         noExit: true,
-        quiet: true,
         beforeEach: prepareService,
         afterEach: crashItAgain,
       });