Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): improve validations, recursions, logs and imports #346

Merged
merged 11 commits into from
Jun 9, 2024
Merged

Conversation

wellwelwel
Copy link
Owner

@wellwelwel wellwelwel commented Jun 7, 2024

Screenshot 2024-06-08 at 17 00 13
  • A same success and a failure test for each one, using the default settings.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 95.14170% with 12 lines in your changes missing coverage. Please review.

Project coverage is 95.10%. Comparing base (29add1c) to head (7ea0e22).

Files Patch % Lines
src/services/each.ts 20.00% 4 Missing ⚠️
src/services/run-tests.ts 80.95% 4 Missing ⚠️
src/modules/list-files.ts 97.14% 3 Missing ⚠️
src/helpers/parse-assertion.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   94.72%   95.10%   +0.38%     
==========================================
  Files          30       31       +1     
  Lines        2463     2594     +131     
  Branches      354      373      +19     
==========================================
+ Hits         2333     2467     +134     
+ Misses        128      125       -3     
  Partials        2        2              
Flag Coverage Δ
linux-parallel 94.75% <92.71%> (+0.23%) ⬆️
linux-parallel-options 95.06% <95.14%> (+0.42%) ⬆️
linux-sequential 93.36% <91.49%> (+0.31%) ⬆️
linux-sequential-options 93.63% <93.92%> (+0.50%) ⬆️
osx-parallel 94.75% <92.71%> (+0.23%) ⬆️
osx-parallel-options 95.06% <95.14%> (+0.42%) ⬆️
osx-sequential 93.36% <91.49%> (+0.31%) ⬆️
osx-sequential-options 93.63% <93.92%> (+0.50%) ⬆️
windows-parallel 94.25% <92.71%> (+0.26%) ⬆️
windows-parallel-options 94.56% <95.14%> (+0.45%) ⬆️
windows-sequential 92.86% <91.49%> (+0.33%) ⬆️
windows-sequential-options 93.13% <93.92%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel marked this pull request as ready for review June 9, 2024 18:46
@wellwelwel wellwelwel merged commit 89bcac3 into main Jun 9, 2024
39 checks passed
@wellwelwel wellwelwel deleted the perf branch June 9, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant