Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(simulate|write)Contract payable value not working for overloads #2531

Closed
1 task done
tmm opened this issue Jul 24, 2024 · 1 comment · Fixed by #2561
Closed
1 task done

(simulate|write)Contract payable value not working for overloads #2531

tmm opened this issue Jul 24, 2024 · 1 comment · Fixed by #2561
Labels
A: Types Area: Types Good First Issue Misc: Good First Issue

Comments

@tmm
Copy link
Member

tmm commented Jul 24, 2024

Check existing issues

Viem Version

2.17.11

Current Behavior

If an overloaded function has nonpayable and payable overloads, simulateContract and writeContract's value parameter is not inferred correctly for the payable overload.

Expected Behavior

Payable overload should allow value property.

Steps To Reproduce

No response

Link to Minimal Reproducible Example

https://www.typescriptlang.org/play/?target=99#code/JYWwDg9gTgLgBAbzgYygUwIYzQdQwG3zRgGF9g0A7GAGjgAsYYw6wMoBnNAQQCNg4AXzgAzKBBBwA5ADcKIKXAD0SuDACeYNBwBccAEwA6AIwB2E8YBQoSLERwA7lGDYSEalAzJacDqACu+Fhobh5e8MJiEtJyaCBK4cDuHIoqapraekZmFtbg0PBIIBjAlJTEQqLikrLySsj0JZQpyqoaWroGJubGVpbIyfDI5FTwALwo6MF4hMRkFNQAFAiWcHBeA-7UelIADAAeUjSrKI2lesWl5bQnMJ7NtjB6jMyLAJTHgm-9g+v8cBM2JwePxFgBtE5SERbbxJSi+DAiNAAFXuHCRUAAYtVFhgACZ49AcDh0fGE7QkuD+UowfQAVgAbG8jpDoZRYe4EUjURhmhjsRJcQSiZSySK6NTqPSGXReOpsBw3nA2OoMLwiCyALrfSxOFwhdx3cKLYYLHwrNZiik7A4sy38Y5rNkcygAOQwIDQOw4iJRaP51Tt6ygAHNOmC9vtDNGjtIDtHDLHjLtdpRNY7WnAAAIwDgAWjQ+y03gLUHEUBOMgI-i9cGMlE+3z1rkNnm8JpG1DoFvWwutccOGbVwAzzpgcPdnu9vp5fLQWMDQ9D4cjCdjq5jdGTqboG8T6cr1dr9cblksfhAgWCoSN7dNo27JytxJtg6fDpOY4nHtrUh93P9ecBQUJcwz0CN403Ac1y3FM0wzNIc3zQtixgUty0PfAaz0E9LC+c8AiCFswjvTtzSfPsXwHINh1HGFx3cSdf3-P1eXRIDFyfZdwL3ddIMTWCd2gmMDzWKssOPBs8O+IA

Anything else?

No response
@tmm tmm added Good First Issue Misc: Good First Issue A: Types Area: Types labels Jul 24, 2024
Yuripetusko added a commit to Yuripetusko/viem that referenced this issue Jul 30, 2024
@Yuripetusko
fixed wevm#2531 Correctly infer value type for function overloads bas…
bdc8e4c 
…ed on args
@Yuripetusko Yuripetusko mentioned this issue Jul 30, 2024
Closed
Yuripetusko added a commit to Yuripetusko/viem that referenced this issue Jul 30, 2024
@Yuripetusko
fixed wevm#2531 Correctly infer value type for function overloads bas…
954baf5 
…ed on args
@Yuripetusko Yuripetusko mentioned this issue Jul 30, 2024
Merged
@tmm tmm closed this as completed in #2561 Aug 6, 2024
tmm added a commit that referenced this issue Aug 6, 2024
@Yuripetusko @tmm
fixes #2531 value type on function overload (#2561)
1c5d64a 
* fixes #2560  value type on function overload

* Create new-hotels-sell.md

* revert GetValue changes and create new GetMutabilityAwareValue type

* remove un-used test

* revert test abi

* use mutability aware type util on writeContract too

* fix: wrong import

* lint

* fix import

* Update .changeset/new-hotels-sell.md

---------

Co-authored-by: Tom Meagher <tom@meagher.co>
@github-actions GitHub Actions
Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Viem version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A: Types Area: Types Good First Issue Misc: Good First Issue
Projects
None yet
Milestone
No milestone
1 participant
@tmm