Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #2306 repro #2308

Merged
merged 3 commits into from
May 25, 2024
Merged

chore: #2306 repro #2308

merged 3 commits into from
May 25, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented May 25, 2024

PR-Codex overview

The focus of this PR is to add tests for verifying typed data signatures with checksum addresses.

Detailed summary

  • Added a new test case for verifying typed data signatures with checksum and non-checksum addresses
  • Updated test logic to handle valid and invalid checksum addresses
  • Added assertions for successful and failed signature verification

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem 🔄 Building (Inspect) Visit Preview May 25, 2024 0:18am

Copy link

changeset-bot bot commented May 25, 2024

⚠️ No Changeset found

Latest commit: c1bc314

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jxom jxom merged commit 4135e16 into main May 25, 2024
10 of 20 checks passed
@jxom jxom deleted the 2306 branch May 25, 2024 00:18
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 56.85 KB (0%) 1.2 s (0%) 10.6 s (-23.37% 🔽) 11.8 s
viem (cjs) 68.27 KB (0%) 1.4 s (0%) 10.8 s (+28.9% 🔺) 12.2 s
viem (minimal surface - tree-shaking) 3.31 KB (0%) 67 ms (0%) 104 ms (-11.14% 🔽) 171 ms
viem/accounts 73.9 KB (0%) 1.5 s (0%) 2.9 s (-52.47% 🔽) 4.4 s
viem/accounts (tree-shaking) 19.2 KB (0%) 385 ms (0%) 1.7 s (-12.57% 🔽) 2.1 s
viem/actions 41.73 KB (0%) 835 ms (0%) 2.3 s (-73.68% 🔽) 3.1 s
viem/actions (tree-shaking) 318 B (0%) 10 ms (0%) 54 ms (-3.79% 🔽) 64 ms
viem/chains 27.86 KB (+0.03% 🔺) 558 ms (+0.03% 🔺) 9 s (+60.33% 🔺) 9.6 s
viem/chains (tree-shaking) 324 B (0%) 10 ms (0%) 35 ms (-92.95% 🔽) 45 ms
viem/chains/utils 1.02 KB (0%) 21 ms (0%) 49 ms (-26.9% 🔽) 69 ms
viem/ens 41.73 KB (0%) 835 ms (0%) 2.5 s (-37.2% 🔽) 3.3 s
viem/ens (tree-shaking) 18.4 KB (0%) 369 ms (0%) 4.3 s (-22.35% 🔽) 4.7 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant