Merge pull request #77 from tessus/change-1

minor improvements
whomwah · Feb 4, 2020 · 0a8dd24 · 0a8dd24
2 parents b27ffbe + 6f27fa1
commit 0a8dd24
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 45 deletions.
diff --git a/Makefile b/Makefile
@@ -0,0 +1,19 @@
+.PHONY: QuickLookStephen debug clean
+
+QuickLookStephen:
+	xcodebuild SYMROOT=../build -project QuickLookStephenProject/QuickLookStephen.xcodeproj -configuration "Release" $(XC_OPTIONS) build
+
+debug:
+	xcodebuild SYMROOT=../build -project QuickLookStephenProject/QuickLookStephen.xcodeproj -configuration "Debug" $(XC_OPTIONS) build
+
+install:
+	@if [ -d  "./build/Release/QLStephen.qlgenerator" ]; then \
+		rm -rf ~/Library/QuickLook/QLStephen.qlgenerator ; \
+		cp -r ./build/Release/QLStephen.qlgenerator ~/Library/QuickLook/ ; \
+		qlmanage -r ; \
+	else \
+		echo "Sorry, nothing to install. You might want to build it first. ;-)"; \
+	fi
+
+clean:
+	@rm -rf ./build
diff --git a/QuickLookStephenProject/QuickLookStephen.xcodeproj/project.pbxproj b/QuickLookStephenProject/QuickLookStephen.xcodeproj/project.pbxproj
@@ -21,19 +21,6 @@
 		F28CFC030A3EC0C6000ABFF5 /* QuickLook.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F28CFC020A3EC0C6000ABFF5 /* QuickLook.framework */; };
 /* End PBXBuildFile section */
 
-/* Begin PBXCopyFilesBuildPhase section */
-		3B177A14234CD54A00AA1345 /* CopyFiles */ = {
-			isa = PBXCopyFilesBuildPhase;
-			buildActionMask = 2147483647;
-			dstPath = $HOME/Library/Quicklook;
-			dstSubfolderSpec = 0;
-			files = (
-				3B177A15234CD56200AA1345 /* QLStephen.qlgenerator in CopyFiles */,
-			);
-			runOnlyForDeploymentPostprocessing = 0;
-		};
-/* End PBXCopyFilesBuildPhase section */
-
 /* Begin PBXFileReference section */
 		0107ABFC15C76F2900C65F1A /* QLSFileAttributes.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QLSFileAttributes.h; sourceTree = "<group>"; };
 		0107ABFD15C76F2900C65F1A /* QLSFileAttributes.m */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 2; lastKnownFileType = sourcecode.c.objc; path = QLSFileAttributes.m; sourceTree = "<group>"; tabWidth = 2; usesTabs = 0; };
@@ -131,8 +118,6 @@
 				8D57630F048677EA00EA77CD /* Resources */,
 				8D576311048677EA00EA77CD /* Sources */,
 				8D576313048677EA00EA77CD /* Frameworks */,
-				3B177A14234CD54A00AA1345 /* CopyFiles */,
-				698210201CC62DD000504BBF /* ShellScript */,
 			);
 			buildRules = (
 			);
@@ -150,7 +135,7 @@
 		089C1669FE841209C02AAC07 /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 1110;
+				LastUpgradeCheck = 1010;
 			};
 			buildConfigurationList = 2CA326220896AD4900168862 /* Build configuration list for PBXProject "QuickLookStephen" */;
 			compatibilityVersion = "Xcode 3.2";
@@ -180,22 +165,6 @@
 		};
 /* End PBXResourcesBuildPhase section */
 
-/* Begin PBXShellScriptBuildPhase section */
-		698210201CC62DD000504BBF /* ShellScript */ = {
-			isa = PBXShellScriptBuildPhase;
-			buildActionMask = 2147483647;
-			files = (
-			);
-			inputPaths = (
-			);
-			outputPaths = (
-			);
-			runOnlyForDeploymentPostprocessing = 0;
-			shellPath = /bin/sh;
-			shellScript = "qlmanage -r\n";
-		};
-/* End PBXShellScriptBuildPhase section */
-
 /* Begin PBXSourcesBuildPhase section */
 		8D576311048677EA00EA77CD /* Sources */ = {
 			isa = PBXSourcesBuildPhase;
@@ -225,6 +194,7 @@
 		2CA3261F0896AD4900168862 /* Debug */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
+				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ENABLE_OBJC_ARC = YES;
 				COMBINE_HIDPI_IMAGES = YES;
 				COPY_PHASE_STRIP = NO;
@@ -245,6 +215,7 @@
 		2CA326200896AD4900168862 /* Release */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
+				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ENABLE_OBJC_ARC = YES;
 				COMBINE_HIDPI_IMAGES = YES;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
@@ -263,7 +234,6 @@
 		2CA326230896AD4900168862 /* Debug */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
-				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
 				CLANG_WARN_COMMA = YES;
@@ -307,7 +277,6 @@
 		2CA326240896AD4900168862 /* Release */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
-				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
 				CLANG_WARN_COMMA = YES;

diff --git a/...tephenProject/QuickLookStephen.xcodeproj/xcshareddata/xcschemes/QuickLookStephen.xcscheme b/...tephenProject/QuickLookStephen.xcodeproj/xcshareddata/xcschemes/QuickLookStephen.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1110"
+   LastUpgradeVersion = "1010"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/README.md b/README.md
@@ -8,14 +8,14 @@ QLStephen is a QuickLook plugin that lets you view plain text files without a fi
     CHANGELOG
     etc...
 
-
 ## Installation
 
 ### Homebrew
 
     brew cask install qlstephen
-
-## MacPorts
+
+### MacPorts
+
     port install qlstephen
 
 ### Pre-compiled
@@ -25,11 +25,12 @@ QLStephen is a QuickLook plugin that lets you view plain text files without a fi
 * Copy the file into `/Library/QuickLook` or `~/Library/QuickLook`
   (You can create the `QuickLook` folder if it doesn’t exist)
 
-
 ### Manually Compiled
 
-Compiling the project yourself? The build process will copy the file into `~/Library/QuickLook`.
+Compiling the project yourself? Run:
 
+    make
+    make install
 
 ## Settings
 
@@ -38,16 +39,15 @@ Compiling the project yourself? The build process will copy the file into `~/Lib
 To keep quickview fast the preview is limited in its number of shown bytes.
 The default value is 100kB. You can change this using the shell to set your own max size.
 
-	defaults write com.whomwah.quicklookstephen maxFileSize 102400
-
+    defaults write com.whomwah.quicklookstephen maxFileSize 102400
 
 ## Trouble?
 
 If you’ve installed the plugin, but don’t see any changes:
 
 - Make sure you are editing (a) the correct plist of (b) the correct bundle.
   (For example, you might have two `QLStephen` plugins. It’s possible the plugin in
-   another directory —perhaps `/Library/QuickLook/`— is what is being read.)
+   another directory — perhaps `/Library/QuickLook/` — is what is being read.)
 - Run `qlmanage -r` in the Terminal. (This will restart QuickLook, which reloads all plugins.)
 
 If you want to preview some text files that _do_ have extensions (e.g., `*.txt`), follow [these instructions](https://github.com/whomwah/qlstephen/issues/23).
@@ -56,7 +56,6 @@ If you want to preview some text files that _do_ have extensions (e.g., `*.txt`)
 
 Because I was listening to [Adam and Joe](http://www.bbc.co.uk/blogs/adamandjoe/2009/06/test-1.shtml) when I first wrote it.
 
-
 ## Authors
 
 **Original author:** Duncan Robertson
@@ -69,7 +68,6 @@ Special thanks to the following people for submitting patches over the years:
 * [Tony](https://github.com/Zearin)
 * [Nicholas Hutchinson](https://github.com/nickhutchinson)
 
-
 ## Contributing
 
 * Fork the project