.DS_Store hangs/crash on Yosemite

[mafrost]

In Yosemite, (never happened for me in Mavericks and before) Finder hangs when quick look tries to open .DS_Store files. I've tried adding .DS_Store to blacklist but it doesn't work. No matter if I restart computer or whatever it hangs everytime I try to quick look a .DS_Store.

[mskblackbelt]

I have the same issue… any updates on this? Uninstalling qlstephen took care of this, but I did enjoy the utility of viewing most unlabeled files.

[bestwnh]

Hi Guys. I have tried this plugin in Yosemite and no hangs/crash with .DS_Store file.(But it also not showing the .DS_Store file plain text view, just a simple file detail view like before)

Are you using the newest release? If so would you mind to upload one of your .DS_Store making crash? Remember to zip it before you upload it.

[mskblackbelt]

Dumped my latest Finder hang to a gist here. Had to force quite Finder (Relaunch by right-clicking Dock icon).

Let me know if you need more info.

[bestwnh]

@mskblackbelt ,I just simple test your file and it just work fine on my 10.10...
Could you please list all plugins in folder
~/Library/QuickLook
and
/Library/QuickLook

And also upload the QLStephen.qlgenerator that you using in your system.

[bestwnh]

@mskblackbelt ,Sorry I don't see that's your error dump.
I will check it later and see what useful in it.

Again, could you upload a .DS_Store sample? And the things I mention above. It may help a lot.

[mskblackbelt]

~/Library/QuickLook:

• BetterZipQL.qlgenerator
• QLColorCode.qlgenerator
• QLMarkdown.qlgenerator
• QuickLookCSV.qlgenerator
• ScriptQL.qlgenerator

/Library/Quicklook:

• Suspicious Package.qlgenerator
• iBooksAuthor.qlgenerator
• iWork.qlgenerator

The version of qlstephen is the one installed by brew cask, and the url for the file is:
https://github.com/downloads/whomwah/qlstephen/QLStephen.qlgenerator.zip

You can see a sample .DS_Store file here:
[https://dl.dropboxusercontent.com/u/219174/Sample%20.DS_Store]{https://dl.dropboxusercontent.com/u/219174/Sample%20.DS_Store}

Let me know if you have issues downloading that… I renamed it, as the Public folder already contains a .DS_Store file.

After looking at the .DS_Store file, not every one triggers the crash, but the ones that do also trigger a crash in TextMate. From this, I gather that the .DS_Store files are badly encoded, and so perhaps a better solution would be to prevent the qlstephen plugin from attempting to view them… Is this solution possible to implement? I'm completely unfamiliar with Obj-C, so I wouldn't know where to begin with editing the code.

[bestwnh]

@mskblackbelt
I add some code and ignore the .DS_Store file. And it should be OK for you.
You can get the updated code in my fork: https://github.com/bestwnh/qlstephen
If you don't want to build it again, you can use the version I build: https://www.dropbox.com/s/1voh3bowlquf43x/QLStephen.qlgenerator.zip?dl=0

Hope this make some help.

[mskblackbelt]

@bestwnh

That seems to have fixed the issue; thanks for your efforts!

[SteveBenner]

While unrelated to the actual plugin, I’d just like to point out that .DS_Store files are such a huge pain that it’s usually better to just avoid using them at all; to that end I would _highly_ recommend installing Asepsis. I’ve been super happy with the results and haven’t looked back.

You can install with brew cask install asepsis if you have Homebrew Cask installed (which you should)

[bestwnh]

Thanks Steve, but I really don't like to change the file structure. Improve is good enough, change would make some risk. You make your choice.

[kevinSuttle]

Works for me! Thanks!

[tsdorsey]

I no longer saw this issue on OSX 10.11.4 but #39 should make sure it never comes back.