Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .DS_Store file #39

Merged
merged 3 commits into from
Apr 19, 2016
Merged

Ignore .DS_Store file #39

merged 3 commits into from
Apr 19, 2016

Conversation

bestwnh
Copy link
Contributor

@bestwnh bestwnh commented Nov 23, 2014

The .DS_Store file make some user's finder hang/crash. And it's also un-readable. So I just ignore the file with this name to prevent the issue: #34

…dable)

Default not to analyzer for Xcode 6 to build
Some project setting auto update
…gexKitLite.m for Xcode 6 to make it through.
@tsdorsey
Copy link
Collaborator

tsdorsey commented Feb 2, 2016

@tomfado Hi Tomas. After forking this project I contacted @whomwah about changing the source of the homebrew-cask to my repo so that development could continue. He had the much better idea of adding me to this project. He listed you as the new maintainer so I want to talk to you before I start making changes.

If you look at my repo you can see I've merged the pull requests open on this repo into mine. It does fix some of the open issues (the .DS_Store hang being the biggest one).

I'd like to do the following:

  1. Merge all open pull requests.
  2. Close the issues that are fixed by them.
  3. Ask @comawill for the travis integration. (Would you mind opening a pull request @comawill?)
    • Setup travis integration and add build badges to readme.
  4. Draft a 1.4.3 release
  5. Release 1.4.3

Thoughts? Are you ok with me doing these things? Thank you.

@tomfado
Copy link
Collaborator

tomfado commented Feb 4, 2016

Hi Trevor

Thank you for your effort. I have not been able to put any time into
this project, despite my initial intentions. How about you ask Duncan to
become the new maintainer? Are you interested? I am more than happy to
back down. I like the project very much though and would like it to be
well and prosper.

And even if you don't want to become a maintainer, you're more than
welcome to do what you suggested.

Best regards

Tomas Fasth

Den 2016-02-02 kl. 19:00, skrev Trevor Dorsey:

@tomfado https://github.com/tomfado Hi Tom. After forking this project
I contacted @whomwah https://github.com/whomwah about changing the
source of the homebrew-cask to my repo so that development could
continue. He had the much better idea of adding me to this project. He
listed you as the new maintainer so I want to talk to you before I start
making changes.

If you look at my repo you can see I've merged the pull requests open on
this repo into mine. It does fix some of the open issues (the .DS_Store
hang being the biggest one).

I'd like to do the following:

  1. Merge all open pull requests.
  2. Close the issues that are fixed by them.
  3. Ask @comawill https://github.com/comawill for the travis
    integration. (Would you mind opening a pull request @comawill
    https://github.com/comawill?)
  4. Draft a 1.4.3 release
  5. Release 1.4.3

Thoughts? Are you ok with me doing these things? Thank you.


Reply to this email directly or view it on GitHub
#39 (comment).

Tomas Fasth tomfa@debian.org
Debian Developer
GPG fingerprint: B9BC EDE2 9580 516A EA8C 34E7 33C1 FE3D 81D7 2FF8

@comawill comawill mentioned this pull request Mar 8, 2016
@tsdorsey tsdorsey merged commit 9aa967b into whomwah:master Apr 19, 2016
@bestwnh
Copy link
Contributor Author

bestwnh commented Apr 19, 2016

Finally👏👏👏👏👏👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants