Correctly marshal/unmarshal struct fields of slice type with nil values to/from CborNull #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently struct fields of slice type with nil values will be marshalled into empty slice, not Null representation in CBOR.
For example:
Currently,
e1
ande2
will be marshalled into the same byte sequence, which will all be unmarshalled into the same value ase2
. So below will fail, which is undesirable IMO:This PR fix it by correctly marshal/unmarshal struct fields of slice type with nil values to/from CborNull