op is nil panic if error DeleteInstance

whywaita · Mar 6, 2024 · 98949bf · 98949bf
1 parent 127a8a0
commit 98949bf
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/server/pkg/api/server_add_instance.go b/server/pkg/api/server_add_instance.go
@@ -84,6 +84,7 @@ func (s *ShoesLXDMultiServer) AddInstance(ctx context.Context, req *pb.AddInstan
 		op, err := client.DeleteInstance(instanceName)
 		if err != nil {
 			l.Warn("failed to delete instance", "err", err.Error())
+			return nil, status.Errorf(codes.Internal, "failed to wait starting instance: %+v", err)
 		}
 		if err := op.Wait(); err != nil {
 			l.Warn("failed to wait deleting instance", "err", err.Error())
@@ -97,6 +98,7 @@ func (s *ShoesLXDMultiServer) AddInstance(ctx context.Context, req *pb.AddInstan
 		op, err := client.DeleteInstance(instanceName)
 		if err != nil {
 			l.Warn("failed to delete instance", "err", err.Error())
+			return nil, status.Errorf(codes.Internal, "failed to wait starting instance: %+v", err)
 		}
 		if err := op.Wait(); err != nil {
 			l.Warn("failed to wait deleting instance", "err", err.Error())