Parallel GetResources

server/pkg/api/server_add_instance.go

@@ -2,14 +2,16 @@ package api
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"log"
 	"math/rand"
 	"net/url"
 	"sort"
 	"strconv"
 	"strings"
+	"sync"
+
+	"golang.org/x/sync/errgroup"
 
 	lxd "github.com/lxc/lxd/client"
 	"github.com/lxc/lxd/shared/api"
@@ -121,29 +123,50 @@ type targetHost struct {
 }
 
 func (s *ShoesLXDMultiServer) scheduleHost(targetLXDHosts []lxdclient.LXDHost) (*lxdclient.LXDHost, error) {
+	targets, err := getResources(targetLXDHosts)
+	if err != nil {
+		return nil, fmt.Errorf("failed to get resources: %w", err)
+	}
+
+	target, err := schedule(targets, s.overCommitPercent)
+	if err != nil {
+		return nil, fmt.Errorf("failed to schedule: %w", err)
+	}
+	return &(target.host), nil
+}
+
+func getResources(targetLXDHosts []lxdclient.LXDHost) ([]targetHost, error) {
 	var targets []targetHost
 
+	eg := errgroup.Group{}
+	mu := sync.Mutex{}
+
 	for _, t := range targetLXDHosts {
-		resources, err := lxdclient.GetResource(t.HostConfig)
-		if err != nil {
-			if errors.Is(err, lxdclient.ErrTimeoutConnectLXD) {
-				continue
+		t := t
+		eg.Go(func() error {
+			resources, err := lxdclient.GetResource(t.HostConfig)
+			if err != nil {
+				log.Printf("failed to get resource (host: %s): %+v\n", t.HostConfig.LxdHost, err)
+				return nil
 			}
 
-			return nil, fmt.Errorf("failed to get resource (host: %s): %w", t.HostConfig.LxdHost, err)
-		}
+			mu.Lock()
+			targets = append(targets, targetHost{
+				host:              t,
+				resource:          *resources,
+				percentOverCommit: lxdclient.GetCPUOverCommitPercent(*resources),
+			})
+			mu.Unlock()
 
-		targets = append(targets, targetHost{
-			host:              t,
-			resource:          *resources,
-			percentOverCommit: lxdclient.GetCPUOverCommitPercent(*resources),
+			return nil
 		})
 	}
-	target, err := schedule(targets, s.overCommitPercent)
-	if err != nil {
-		return nil, fmt.Errorf("failed to schedule: %w", err)
+
+	if err := eg.Wait(); err != nil {
+		return nil, fmt.Errorf("failed to get resources: %w", err)
 	}
-	return &(target.host), nil
+
+	return targets, nil
 }
 
 var (