feat(stream): Add AsciiChar
#459
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `A` is generic, it is capital which makes it less likely to collide and people don't have to use the prelude.
Pull Request Test Coverage Report for Build 7817064688
💛 - Coveralls |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 42.67% 41.58% -1.09%
==========================================
Files 18 19 +1
Lines 3084 3179 +95
==========================================
+ Hits 1316 1322 +6
- Misses 1768 1857 +89 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const fn gen() -> &'static [AsciiChar] { | ||
| crate::stream::AS!("a") | ||
| } | ||
| const S: &'static [AsciiChar] = gen(); |
Check failure
Code scanning / clippy
constants have by default a 'static lifetime Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used like
u8orcharbut its guaranteed to work with both byte streams and&strstreams.A
A!macro is introduced to provide a "literal" form of this for easier creation. An invalid value is a compiler error.The goal is to resolve issues where we could end up splitting on non-UTF8 characters because we allow bytes to be used with
&strbut we need something that can work with both.