fit for color + zeropoint using x and y uncertainties #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertdstein
requested changes
Feb 13, 2024
robertdstein
approved these changes
Feb 14, 2024
virajkaram
reviewed
Feb 14, 2024
mirar/processors/photcal/zp_calculator/color_term_zp_calculator.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR utilizes
scipy.odrinsideZPWithColorTermCalculatorto fit a line using the x and y uncertainties in the color vs. differential mag plot.Room for improvement: for the ODR to work, we can't use data with 0 uncertainty (in x or y). In quite a few lines of code, I added some code that removes those points with 0 uncertainty. This could certainly be compressed. But also, 0 uncertainty in x would only happen if the reference catalog reports 0 uncertainty for both magnitudes of interest, which should be a red flag anyways. So, I feel this cut belongs somewhere else... in a reference catalog purifier? But one that everyone should use... let me know your thoughts @virajkaram @robertdstein