Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle None values in DBInserter #771

Merged
merged 8 commits into from
Feb 21, 2024
Merged

Handle None values in DBInserter #771

merged 8 commits into from
Feb 21, 2024

Conversation

robertdstein
Copy link
Member

np.unique cannot deal with None, so swap to pd.unique.

Also implement weighting for ra/dec in WINTER source table.

Also also add WINTER configuration for full_subset, which is just full but for one board.

@coveralls
Copy link

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 7996823094

Details

  • 25 of 37 (67.57%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 86.374%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mirar/pipelines/winter/generator.py 8 20 40.0%
Files with Coverage Reduction New Missed Lines %
mirar/monitor/base_monitor.py 1 83.0%
Totals Coverage Status
Change from base Build 7980158652: -0.06%
Covered Lines: 10085
Relevant Lines: 11676

💛 - Coveralls

@virajkaram virajkaram self-requested a review February 21, 2024 22:25
@robertdstein robertdstein enabled auto-merge (squash) February 21, 2024 23:20
@robertdstein robertdstein merged commit d9467f5 into main Feb 21, 2024
14 of 16 checks passed
@robertdstein robertdstein deleted the dbfix branch February 21, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants