-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boardid 6 #826
Merged
Merged
Boardid 6 #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8527749676Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 8527749676Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 8531297293Details
💛 - Coveralls |
robertdstein
requested changes
Apr 3, 2024
robertdstein
approved these changes
Apr 3, 2024
This was
linked to
issues
Apr 3, 2024
saarahhall
pushed a commit
to saarahhall/mirar
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing for new boardid=6, with a bad channel. The images are masked throughout processing, except in the pre-stack stage where swarp cannot handle the masked values distributed throughout the image, producing a fully masked image.
To get around this, the masked pixels are replaced with the median of the entire image in the pre-stack step.
More sophisticated options (local median instead of global median?) will be explored in future PRs.
Also updates the way subdetid dataframe is calculated to ensure compatibility with existing boardid->subdetid mapping.