Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boardid 6 #826

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Boardid 6 #826

merged 12 commits into from
Apr 3, 2024

Conversation

virajkaram
Copy link
Collaborator

@virajkaram virajkaram commented Apr 2, 2024

Processing for new boardid=6, with a bad channel. The images are masked throughout processing, except in the pre-stack stage where swarp cannot handle the masked values distributed throughout the image, producing a fully masked image.
To get around this, the masked pixels are replaced with the median of the entire image in the pre-stack step.
More sophisticated options (local median instead of global median?) will be explored in future PRs.
Also updates the way subdetid dataframe is calculated to ensure compatibility with existing boardid->subdetid mapping.

@virajkaram virajkaram marked this pull request as ready for review April 2, 2024 07:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8527749676

Details

  • 13 of 18 (72.22%) changed or added relevant lines in 4 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 86.508%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mirar/pipelines/winter/load_winter_image.py 2 3 66.67%
mirar/pipelines/winter/generator.py 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
mirar/database/user/postgres_admin.py 5 77.27%
mirar/paths.py 6 95.52%
Totals Coverage Status
Change from base Build 8518362334: 0.09%
Covered Lines: 10406
Relevant Lines: 12029

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8527749676

Details

  • 13 of 18 (72.22%) changed or added relevant lines in 4 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 86.508%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mirar/pipelines/winter/load_winter_image.py 2 3 66.67%
mirar/pipelines/winter/generator.py 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
mirar/database/user/postgres_admin.py 5 77.27%
mirar/paths.py 6 95.52%
Totals Coverage Status
Change from base Build 8518362334: 0.09%
Covered Lines: 10406
Relevant Lines: 12029

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 2, 2024

Pull Request Test Coverage Report for Build 8531297293

Details

  • 17 of 22 (77.27%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 86.402%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mirar/pipelines/winter/load_winter_image.py 2 3 66.67%
mirar/pipelines/winter/generator.py 7 11 63.64%
Totals Coverage Status
Change from base Build 8518362334: -0.02%
Covered Lines: 10427
Relevant Lines: 12068

💛 - Coveralls

mirar/pipelines/winter/constants.py Outdated Show resolved Hide resolved
mirar/pipelines/winter/load_winter_image.py Outdated Show resolved Hide resolved
mirar/pipelines/winter/load_winter_image.py Show resolved Hide resolved
@virajkaram virajkaram enabled auto-merge (squash) April 3, 2024 00:39
@virajkaram virajkaram disabled auto-merge April 3, 2024 00:44
@virajkaram virajkaram merged commit 1654dff into main Apr 3, 2024
14 of 16 checks passed
@virajkaram virajkaram deleted the masking branch April 3, 2024 05:21
saarahhall pushed a commit to saarahhall/mirar that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Still not processing boardid 6 [FEATURE] Pixel Mask for StarB
3 participants