Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sgscore and filter isdiffpos #837

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add sgscore and filter isdiffpos #837

merged 1 commit into from
Apr 12, 2024

Conversation

robertdstein
Copy link
Member

Fix #797

virajkaram
virajkaram approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@virajkaram virajkaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you add that this PR also filters on isdiffpos to the description?
  2. Do we want to add sgscore to the db?

@robertdstein robertdstein changed the title Add sgscore Add sgscore and filter isdiffpos Apr 12, 2024
@robertdstein
Copy link
Member Author

@virajkaram, I have just discovered that sgscore is apparently already IN the database, so presumably it is now going to get populated. I changed the name of the PR though. Thanks!

@robertdstein robertdstein enabled auto-merge (squash) April 12, 2024 03:24
@robertdstein robertdstein merged commit 60b9e01 into main Apr 12, 2024
14 of 16 checks passed
@robertdstein robertdstein deleted the sgscore branch April 12, 2024 05:21
saarahhall pushed a commit to saarahhall/mirar that referenced this pull request May 8, 2024
@robertdstein @saarahhall
Add sgscore and filter isdiffpos (winter-telescope#837)
c65642e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajkaram virajkaram virajkaram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] sgscore for WINTER
2 participants
@robertdstein @virajkaram