-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Ace Editor with Monaco Editor #801
base: develop
Are you sure you want to change the base?
Conversation
- Add most configuration options - Dispose and create editor depending on whether in view - Fix sizing issue
|
modules/backend/controllers/preferences/_field_editor_preview.php
Outdated
Show resolved
Hide resolved
… events for editor
It appears to be a lot better for showing Markdown formatting.
- Prevent context error when editor refreshes after resize event - Fix issue where editor continually increases height when code editor is in a fluid height container (ie. "stretch" fields)
This allows prepending of content for the code editor that cannot be edited by the end-user.
@bennothommo what's the status of this? |
When I last worked on this, I was having some dramas with the Markdown editor, since that also had to be converted to Monaco. I was hesitant to include another editor just for the Markdown editor, but if we can find a lean one, I'm happy to use that instead and keep Monaco for just the code editing (which it works amazingly with). |
What's the problem with the markdown editor? Does it currently use ace? |
Yeah it uses Ace currently. I feel keeping Ace around and introducing Monaco for the code editor might be too much "bloat". |
I'm fine with having both if we can clearly identify all the locations we can remove Ace from as soon as we get a replacement for the usage of Ace in the markdown editor; that way at least it won't hold us up from getting the benefits of monaco and it'll be simple enough to remove Ace when we replace the markdown editor. Any thoughts on that? |
Fixes #431.
This PR introduces the Monaco editor in replacement of the Ace Editor. At this stage for the PR, we are aiming for parity with the functionality previously provided by Ace, with the intention of increasing the functionality after this PR is merged.
Still to do:
Changes: