Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Update Sharp optionalDep version #9463

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

Princesseuh
Copy link
Member

Changes

I'm not too sure, but I think this is the cause of all the recents Sharp-related issues like #9345

Since Sharp changed its installation method in its latest version, mixing versions can get weird and certain package managers seems to have issues handling it. I've never been able to reproduce any issues, so I can't really tell what the problem is, nonetheless I believe this should fix it!

Testing

Can't really test if it fixes the issue or not, but it should still work.

Docs

N/A

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: d0f9198

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 18, 2023
@ematipico ematipico merged commit 3b0eaed into main Dec 22, 2023
13 checks passed
@ematipico ematipico deleted the fix/sharp-version branch December 22, 2023 10:52
@astrobot-houston astrobot-houston mentioned this pull request Dec 22, 2023
@jlarmstrongiv
Copy link

@Princesseuh unfortunately, the latest version of sharp still breaks when bundling deployments, see vercel/ncc#1153

Would you allow the installation of an older version of sharp (specifically, at least 0.32.6) for the time being?

@Princesseuh
Copy link
Member Author

@Princesseuh unfortunately, the latest version of sharp still breaks when bundling deployments, see vercel/ncc#1153

Would you allow the installation of an older version of sharp (specifically, at least 0.32.6) for the time being?

It's an optionalDep, so you should be able to install whatever version of Sharp you prefer, I think!

@jlarmstrongiv
Copy link

image

It seems sharp@0.33.1 is still being installed for me, but I have a different workaround to force 0.32.6 for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants