-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move site title href
to route data for easier overrides
#1842
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: 73ad8e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Welcome, Does this got a confirmation and will be published soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it out and it works perfectly 🙌
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
* main: i18n(zh-cn): Update `overrides.md` (withastro#1864) [ci] format [ci] release (withastro#1839) Add comment and heart icons (withastro#1837) [ci] format Add HackerOne Icon (withastro#1840) Update Vietnamese translation (withastro#1863) Move site title `href` to route data for easier overrides (withastro#1842)
Description
<SiteTitle>
calculates the value of its link internally. This makes it tricky for people to set the link while reusing the default component implemenation.siteTitleHref
property to the route data object (and the one forStarlightPage
), moving the logic for working out the link path there.Astro.props.siteTitleHref = '/custom-link/'
if you need and still use the default component implementation.Considerations
siteTitleHref
for now, but it could also be something more generic likehomeLink
I guess?