Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discourse to social icons #1909

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Add discourse to social icons #1909

merged 4 commits into from
Jun 4, 2024

Conversation

joshka
Copy link
Contributor

@joshka joshka commented May 21, 2024

Description

Forum software - https://discourse.org/

The middle icon is the new icon (in the context of https://github.com/ratatui-org/ratatui-website/)
image

Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 119d5c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview May 21, 2024 10:57am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label May 21, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @joshka! Have one small suggestion.

I might also move the new discourse entry in Icons.ts up to be with the other social icons although we don’t have a strict rule about this, i.e. I guess immediately after blueSky would make sense to keep social platforms roughly grouped together.

packages/starlight/components/Icons.ts Outdated Show resolved Hide resolved
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@joshka
Copy link
Contributor Author

joshka commented May 21, 2024

I might also move the new discourse entry in Icons.ts up to be with the other social icons although we don’t have a strict rule about this, i.e. I guess immediately after blueSky would make sense to keep social platforms roughly grouped together.

done in 39de623

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @joshka — looks great 🙌

Will merge this when we’re ready to cut our next patch release. (Merged PRs go live in our docs immediately, so we hold off until just before release to avoid someone seeing a feature in the docs that isn’t actually available yet.)

@delucis delucis added the 🌟 patch Change that triggers a patch release label May 21, 2024
@delucis delucis merged commit c98c708 into withastro:main Jun 4, 2024
11 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jun 4, 2024
joshka added a commit to ratatui/ratatui-website that referenced this pull request Jun 4, 2024
joshka added a commit to ratatui/ratatui-website that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants