Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new social icon for Zulip #1978

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Conversation

kylewlacy
Copy link
Contributor

Description

Closes #1952. This PR adds a new social icon for the chat platform Zulip. Here's how the new logo would look on the Starlight docs site (to the right of the Discord and GitHub logos):

Starlight docs site header, showing the existing GitHub and Discord logos next to the Zulip logo

I based the logo on the file zulip-icon-circle.svg from the Zulip repo. The repo is Apache 2.0-licensed, but based on zulip/zulip#13906, my impression was that the Zulip team didn't have a specific license for their logo but were open to usage when used for linking to Zulip itself (I will post in that issue to see if they would have any concerns about this PR as well, for good measure).

The original SVG itself featured the background circle and the inner "Z" as separate elements, so I basically just grabbed the "Z", scaled/positioned it, and saved it as its own SVG. I also tried having a negative "Z" within a circle, but felt that didn't read as well at a smaller scale.

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 57b760c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jun 8, 2024 6:14am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jun 7, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @kylewlacy! Noticed on small opportunity for improvement, but otherwise this PR looks perfect 🙌

packages/starlight/components/Icons.ts Outdated Show resolved Hide resolved
@delucis delucis added the 🌟 patch Change that triggers a patch release label Jun 7, 2024
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @kylewlacy! Will get this released now.

@delucis delucis merged commit a5ab8cd into withastro:main Jun 9, 2024
11 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jun 9, 2024
@kylewlacy kylewlacy deleted the add-zulip-logo branch June 9, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants