-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: using wrong field to deconstruct in 'CallToAction' component #2182
Conversation
🦋 Changeset detectedLatest commit: 2abab7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
Hi @hartmut-co-uk! Thanks for the PR. I believe this code is working as expected. You can pass extra attributes using the ---
title: My Home Page
hero:
title: 'My project with custom action appearance'
actions:
- text: Tell me more
link: /getting-started/
attrs:
class: more-link
- text: View on GitHub
link: https://github.com/astronaut/my-project
attrs:
class: github-link
--- If you still believe there to be a bug please open an issue with a reproduction so we have a bit more context on what is not working. |
OK, thanks Understood @delucis! <CallToAction attrs={{class: "minimal"}} link="/abc/">...</CallToAction> |
Ah cool, yes that’s not officially supported yet, but the experience will be improved once we merge #1784 — which removes |
Description
Closes (no issue created)
What does this PR change?
<CallToAction class="px-1">...</CallToAction>
Note: I'm actually not sure if the
Prop
interface definition is correct (attrs?: Omit<HTMLAttributes<'a'>, 'href'> | undefined;
) or what the purpose for this is?!?